Bundle with Rollup #96
Conversation
| const prod = process.env.PRODUCTION | ||
| const mode = prod ? 'production' : 'development' | ||
|
|
||
| console.error(`creating ${mode} bundle...`) |
There was a problem hiding this comment.
Why is this a console.error? (can we also capitalize the first c?)
There was a problem hiding this comment.
Just because that prints to stderr (i.e. metadata) rather than stdout (i.e. data). No actual difference, just force of habit! Can change to console.log (or remove altogether) if you prefer
There was a problem hiding this comment.
It makes me feel weird to console.error on every build, I'd prefer it to be console.log! 😉
| if (id === processShim) return 'export default { argv: [], env: {} }' | ||
| return null | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can we get some comments in the file what this whole block is needed for? We'll need to maintain this, so not having any idea what this is there for is a big unfortunate!
Yep, nothing has changed from earlier |
As discussed in #87. This change only affects people who are using the
distfiles (their app will get smaller and boot faster) and people using Webpack 2 or Rollup (allows them to consume the library as an ES module).