Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stylis 3.2 and use constructor #962

Merged
merged 1 commit into from Jul 1, 2017
Merged

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 1, 2017

This prevents bugs with shared options when different libraries all use
stylis.

cc @thysultan Is the keyframe option for namespacing broken? I'm seeing some regressions with mangled animation names.

Edit:

-@-webkit-keyframes keyframe_880{ from{ opacity: 0; } } @keyframes keyframe_880{ from{ opacity: 0; } } .sc-a{ } .d{ -webkit-animation:keyframe_880 1s both; animation:keyframe_880 1s both; } @-webkit-keyframes keyframe_144{ from{ opacity: 1; } } @keyframes keyframe_144{ from{ opacity: 1; } } .sc-b{ } .c{ -webkit-animation:keyframe_144 1s both; animation:keyframe_144 1s both; }
+@-webkit-keyframes keyframe_880{ from{ opacity: 0; } } @keyframes keyframe_880{ from{ opacity: 0; } } .sc-a{ } .d{ -webkit-animation:keyframe_880-d 1s both; animation:keyframe_880-d 1s both; } @-webkit-keyframes keyframe_144{ from{ opacity: 1; } } @keyframes keyframe_144{ from{ opacity: 1; } } .sc-b{ } .c{ -webkit-animation:keyframe_144-c 1s both; animation:keyframe_144-c 1s both; }

@kitten kitten requested review from geelen and mxstbr July 1, 2017 18:38
@thysultan
Copy link

thysultan commented Jul 1, 2017

Patched in 3.2.1 the bug was with the new Stylis(options) pattern. Specifically the options where not being passed through.

This prevents bugs with shared options when different libraries all use
stylis.
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place we use stylis?

@kitten kitten merged commit eda46df into master Jul 1, 2017
@kitten
Copy link
Member Author

kitten commented Jul 1, 2017

@mxstbr yes, it's pretty contained 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants