Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

Update babylon-parser.js (Add nullishCoalescingOperator) #252

Conversation

kaywyeex
Copy link

@kaywyeex kaywyeex commented Mar 5, 2019

Nullish coalescing, like optional chaining is at stage 1.

We've added our own parserPlugins to processor options, but now we have to maintain ourselves.
This problem is easily solved by adding it to the default plugin list. 🌮

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ac19e03 on kaywyeex:kaywyeex/add-nullishCoalescingOperator into b5491a2 on styled-components:master.

@kaywyeex
Copy link
Author

kaywyeex commented Mar 9, 2019

Bump for justice. 🌮

@chinesedfan
Copy link
Member

Yes, you have to maintain yourselves. If added too much plugins by default, users who don't need them will have slower linting unnecessarily. It looks like a little unfair. But optional chaining was added before options.parserPlugins was supported.

We hope #231 can become a better solution. Let's share ideas there.

@fabb
Copy link
Contributor

fabb commented Nov 28, 2019

Nullish coalescing is now at stage 3 and soon stage 4, it should be added to the default plugin list

fabb added a commit to fabb/stylelint-processor-styled-components that referenced this pull request Nov 28, 2019
nullish coalescing is now at stage 3 and soon stage 4, therefore it should be added to the parser list
styled-components#252
@dimitropoulos
Copy link

for anyone hitting this issue that would like explicit instructions on the temporary resolution of this problem (i.e. temporary until this project adds the rule themselves since this is in the language now), please see here: stylelint/stylelint#4473

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants