This repository has been archived by the owner on May 14, 2021. It is now read-only.
Update Babel parser for Typescript 3.8 syntax support #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason Github claims the Travis run is still pending after almost two weeks, but if you go to details, it's all green. Does anyone know when this could be merged? |
|
@chinesedfan |
This was referenced Oct 1, 2020
chinesedfan
reviewed
Nov 22, 2020
| @@ -79,7 +79,7 @@ | |||
| "stylelint": ">= 10" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/parser": "^7.8.3", | |||
| "@babel/parser": "^7.10.2", | |||
There was a problem hiding this comment.
^ means 7.x. So users can use latest version(7.12.7 now) of @babel/parser.
If you are still using the old version of @babel/parser, check package-lock.json or yarn.lock of your project.
|
Closed as comments above. Sorry for the late review. If I misunderstood something, feel free to remind me. (cc @koba04) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
stylelint-processor-styled-componentsdoes not support the new syntax from Typescript 3.8, likeThis PR fixes that.