bugfix: adding children to emotion jsx function #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug on the xstyled/emotion jsx API makes the children of tags with "css" props to not be rendered:
So, this PR fixes this issue and creates some tests to ensure its stability.
Test plan
3 tests were created:
Before:
![image](https://user-images.githubusercontent.com/4874089/104122181-bb95c100-5343-11eb-9ccc-5cd7b1d0779f.png)
After:
![image](https://user-images.githubusercontent.com/4874089/104122149-9d2fc580-5343-11eb-9eee-c7dd51d4e87f.png)