Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports in examples #1109

Merged
merged 6 commits into from
Aug 29, 2018
Merged

Imports in examples #1109

merged 6 commits into from
Aug 29, 2018

Conversation

sapegin
Copy link
Member

@sapegin sapegin commented Aug 27, 2018 •
edited

Implements #1074, see the issue for more details.

image 2018-08-27 at 11 59 59 am

@sapegin sapegin added this to the 8.0.0: New editor milestone Aug 27, 2018
@codecov-io
Copy link

codecov-io commented Aug 27, 2018 •
edited

Codecov Report

Merging #1109 into next will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/loaders/utils/getRequires.js 100% <100%> (ø) ⬆️
src/client/utils/compileCode.js 100% <100%> (ø)
...client/rsg-components/ReactExample/ReactExample.js 100% <100%> (ø) ⬆️
src/loaders/examples-loader.js 100% <100%> (ø) ⬆️

@sapegin sapegin merged commit 60b47fc into next Aug 29, 2018
@sapegin sapegin deleted the imports-in-examples-2 branch August 29, 2018 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0: New editor
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapegin @codecov-io