Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in markdown throw React error #140

Closed
marklundin opened this issue May 3, 2016 · 2 comments
Closed

Images in markdown throw React error #140

marklundin opened this issue May 3, 2016 · 2 comments

Comments

@marklundin
Copy link
Contributor

Adding ![image](path/to/image.png) in markdown throws img is a void element tag and must not have 'children' or use 'props.dangerouslySetInnerHTML'. Check the render method of MDReactComponent.

I assume this is actually alexkuz/markdown-react-js#5

@sapegin
Copy link
Member

sapegin commented May 3, 2016

But they work fine?

We should get rid of markdown-react-js: it has lots of issues and it’s dead (no commits since November 2015).

@marklundin
Copy link
Contributor Author

No, nothing renders.

Have you checked http://rexxars.github.io/react-markdown/. Seems to be under active dev and img seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants