Adding Theme UI to Thirdparties docs #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
🎉 This PR is included in version 11.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Theme UI to the docs addresses these two issues that I had yesterday:
Not finding in the first minutes why Styleguidist was not recognizing Theme UI was above all, a SEO issue: Theme UI is not mentioned in the docs, so you never get to Thirdparties through Google.
Once you end up in Thirdparties through the Styleguidist website, you are just going to bypass the "Adding styled-components ThemeProvider" section if your head didn't click yet about the facts that a) you are not passing the ThemeProvider to Styleguidist and b) Theme UI was built with Emotion among other technologies.