Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of CleanWebpackPlugin #1565

Merged
merged 1 commit into from Mar 20, 2020
Merged

Conversation

Lazyuki
Copy link
Contributor

@Lazyuki Lazyuki commented Mar 19, 2020

Was still using an option that no longer exists. Fixed to mimic the original behavior. The option root was removed in v2 but this commit forgot to address it.

It's deleting everything in the styleguidistDir folder which isn't the way it was before.
With this PR, it only deletes files in build/.

Was still using an option that no longer exists. Fixed to mimic the original behavior.
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1565 into master will not change coverage by %.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/scripts/make-webpack-config.ts 100.00% <ø> (ø)

@sapegin sapegin merged commit 3469cbb into styleguidist:master Mar 20, 2020
@sapegin
Copy link
Member

sapegin commented Mar 20, 2020

Nice, thanks!

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants