Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow showing warnings from underlying libraries #1570

Open
bebraw opened this issue Mar 27, 2020 · 1 comment
Open

Allow showing warnings from underlying libraries #1570

bebraw opened this issue Mar 27, 2020 · 1 comment

Comments

@bebraw
Copy link

bebraw commented Mar 27, 2020

The problem

Recently our project was bitten by a known issue in styled-components (styled-components/styled-components#2962 (comment)) that caused our production build to lose all its styling.

The issue itself had to do with the fact that we used an @import to refer to a font and currently that's not supported when building. styled-components gives a build-time warning so developers know to fix this. Personally I would have thrown an Error as it's a fatal issue but they went this way.

Unfortunately, the way our styleguidist is configured, we weren't able to see the warning in time. I tried configuring webpack to emit more but it didn't seem to make a difference.

Proposed solution

Ideally there should be a way to show webpack warnings in styleguidist output to catch these kind of issues.

Alternative solutions

Additional context

@sapegin
Copy link
Member

sapegin commented Mar 27, 2020

Could you try in #1553? I think I did some changes there that may help to see more errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants