Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependencies. #1884

Open
JustFly1984 opened this issue Sep 20, 2021 · 6 comments
Open

Outdated dependencies. #1884

JustFly1984 opened this issue Sep 20, 2021 · 6 comments

Comments

@JustFly1984
Copy link

JustFly1984 commented Sep 20, 2021

I'm a maintainer of @react-google-maps/api package, and I've used styleguidist for our docs for several years. Currently We had migrated from tsdx to rollup, updated react 17 support and typescript@4.4.

Trying to run npx styleguidist server --config ./styleguide.config.js --verbose, but it fails

yarn run v1.22.11
$ npx styleguidist server --config ./styleguide.config.js --verbose
[object Object]
undefined

Also while running yarn install I'm observing dependency issues, so it could be related:

warning " > awesome-typescript-loader@5.2.1" has incorrect peer dependency "typescript@^2.7 || ^3".
warning "react-styleguidist > react-simple-code-editor@0.10.0" has incorrect peer dependency "react@^16.0.0".
warning "react-styleguidist > react-simple-code-editor@0.10.0" has incorrect peer dependency "react-dom@^16.0.0".
warning "react-styleguidist > webpack-dev-server > webpack-dev-middleware@3.7.2" has incorrect peer dependency "webpack@^4.0.0".

the main issue I see is that awesome-typescript-loader was released last time 3 years ago, and I'm sure there should be legit maintainable replacement published since then.

Please respond if styleguidist is still maintained, or I will search for replacement.

Also I see that you had not upgraded webpack to 5+ version yet.

@mmomtchev
Copy link

@JustFly1984 The reason for the cryptic error message is that react-docgen-typescript throws an object that is not an Error when the Typescript compilation fails.
Basically this means that you have a TypeScript compilation problem.
I had the exact same problem and it was due to the fact that TypeScript 4.4 doesn't build the source path in an identical way, I solved it by replacing

require('react-docgen-typescript').withCustomConfig('./tsconfig.json').parse

with

require('react-docgen-typescript').withCustomConfig(path.resolve(__dirname, 'tsconfig.json')).parse

Anyway, this is not a react-styleguidist problem - it is a react-docgen-typescript problem

@lensbart
Copy link

lensbart commented Oct 1, 2021

Here I get the following

➤ YN0002: │ react-styleguidist@npm:11.1.7 [e18ad] doesn't provide webpack (p2fde0), requested by clean-webpack-plugin
➤ YN0002: │ react-styleguidist@npm:11.1.7 [e18ad] doesn't provide webpack (p58619), requested by copy-webpack-plugin
➤ YN0002: │ react-styleguidist@npm:11.1.7 [e18ad] doesn't provide webpack (p4d19f), requested by mini-html-webpack-plugin
➤ YN0002: │ react-styleguidist@npm:11.1.7 [e18ad] doesn't provide webpack (p4767e), requested by terser-webpack-plugin
➤ YN0002: │ react-styleguidist@npm:11.1.7 [e18ad] doesn't provide webpack (p85da1), requested by webpack-dev-server

@JustFly1984
Copy link
Author

@mmomtchev @lensbart @lensbart The next issue I have is with awesome-typescript-loader@5.2.1 - it is unmaintained over 3 years https://www.npmjs.com/package/awesome-typescript-loader, and I'm getting an error: Child process failed to process the request: TypeError: Cannot read property 'getProgram' of undefined at getProgram.

@stale
Copy link

stale bot commented Apr 16, 2022

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Apr 16, 2022
@lensbart
Copy link

I guess this has been fixed

@stale stale bot removed the wontfix label Apr 17, 2022
@DanielHara
Copy link

PR to solve the peer dependency issues:
#2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants