Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] Allow for additional props on component demos (in addition to "View code" and Isolate button) #1935

Open
mogrady88 opened this issue Feb 10, 2022 · 1 comment

Comments

@mogrady88
Copy link

So im not sure if this has been brought up before. I searched the issues and didnt see anything. Im looking for a way to handle some added functionality in component demos. Right now we have the View Code option and the option to route to isolated demo.

Is there a way to add some additional info into the config that would allow us to add something under the demo along with the default actions? See below:

71A17A5C-0F0A-4A12-BA0E-A53A5ECF5D61

What im trying to accomplish is to allow for us to create an elegant way to render large components as full screen( without routing, think of a full screen modal ). I think it would be really clean to be able to add to that demo footer instead of jumbling up the demo body.

Our use case is strictly for full screen functionality but a possible config setting coupled with some sort of parameters in the declaration could be super useful:

```js {file: '../../../someDemo.js, addedButton: {label: '...svg', onClick: ()=>someFunction()} ```

@mogrady88
Copy link
Author

Is this something that you guys would want to see? I can get a branch going and see how viable it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant