Support end positions for warnings

[ybiquitous]

Stylelint 14.7.0 has supported end positions for warnings, and the official VSCode extension prepares the end position support.

So, I suggest stylelint-scss also supports end positions.

Currently, stylelint-scss warns for the whole node, but it seems not good DX:

Reproduction Details

package.json:

{
  "dependencies": {
    "postcss-scss": "4.0.4",
    "stylelint": "14.10.0",
    "stylelint-codeframe-formatter": "1.1.0",
    "stylelint-scss": "4.3.0"
  },
  "scripts": {
    "test": "stylelint \"*.scss\" --custom-formatter stylelint-codeframe-formatter"
  }
}

.stylelintrc.js:

module.exports = {
  plugins: ["stylelint-scss"],
  customSyntax: "postcss-scss",
  rules: {
    "scss/at-rule-no-unknown": true,
    "scss/at-if-no-null": true,
  },
};

a.scss:

@foo {
  // ...
}

a {
  @if $x == null {}
}

---

This will change many files (maybe all rules), but I can help from my experience in the stylelint/stylelint repo.

[ybiquitous]

For example, we can fix scss/at-rule-no-unknown like this:

diff --git a/src/rules/at-rule-no-unknown/index.js b/src/rules/at-rule-no-unknown/index.js
index ef0634c..58801ac 100644
--- a/src/rules/at-rule-no-unknown/index.js
+++ b/src/rules/at-rule-no-unknown/index.js
@@ -83,8 +83,8 @@ export default function rule(primaryOption, secondaryOptions) {
             ruleName,
             result,
             node: warning.node,
-            line: warning.line,
-            column: warning.column
+            start: { line: warning.line, column: warning.column },
+            end: { line: warning.endLine, column: warning.endColumn },
           });
         }
       }

Then, the output is improved:

[kristerkari]

Thanks! This would definitely be a good improvement! :)

[ybiquitous]

@kristerkari Thanks for the response. It seems this task needs many PRs, so I created the following list to make progress clear:

• Fix at-each-key-value-single-line end positions #689
• at-else-closing-brace-newline-after already resolved
• at-else-closing-brace-space-after already resolved
• Fix at-else-empty-line-before end positions #925
• Fix at-else-if-parentheses-space-before end positions #926
• Fix at-extend-no-missing-placeholder end positions #899
• Fix at-function-named-arguments end positions #939
• Fix at-function-parentheses-space-before end positions #927
• Fix at-function-pattern end positions #900
• at-if-closing-brace-newline-after already resolved
• at-if-closing-brace-space-after already resolved
• Fix at-if-no-null end positions #901
• at-import-no-partial-leading-underscore deprecated
• Fix at-import-partial-extension end positions #902
• at-import-partial-extension-blacklist already resolved
• at-import-partial-extension-whitelist already resolved
• Fix at-mixin-argumentless-call-parentheses end positions #928
• Fix at-mixin-named-arguments end positions #940
• Fix at-mixin-parentheses-space-before end positions #929
• Fix at-mixin-pattern end positions #903
• Fix at-root-no-redundant end positions #904
• Fix at-rule-conditional-no-parentheses end positions #930
• Fix at-rule-no-unknown end positions #655
• Fix at-use-no-redundant-alias end positions #905
• Fix at-use-no-unnamespaced end positions #906
• block-no-redundant-nesting already resolved
• comment-no-empty already resolved
• comment-no-loud already resolved
• declaration-nested-properties already resolved
• Fix declaration-nested-properties-no-divided-groups end positions #932
• Fix dimension-no-non-numeric-values end positions #907
• dollar-variable-colon-newline-after already resolved
• dollar-variable-colon-space-after already resolved
• dollar-variable-colon-space-before already resolved
• dollar-variable-default already resolved
• dollar-variable-empty-line-after already resolved
• dollar-variable-empty-line-before already resolved
• dollar-variable-first-in-block already resolved
• Fix dollar-variable-no-missing-interpolation end positions #908
• dollar-variable-no-namespaced-assignment already resolved
• Fix dollar-variable-pattern end positions #909
• double-slash-comment-empty-line-before already resolved
• Fix double-slash-comment-inline end positions #933
• double-slash-comment-whitespace-inside already resolved
• Fix function-calculation-no-interpolation end positions #910
• Fix function-color-relative end positions #911
• Fix function-disallowed-list end positions #912
• function-no-unknown already resolved
• Fix function-quote-no-quoted-strings-inside end positions #934
• Fix function-unquote-no-unquoted-strings-inside end positions #935
• Fix load-no-partial-leading-underscore end positions #913
• Fix map-keys-quotes end positions #914
• media-feature-value-dollar-variable already resolved
• Fix no-dollar-variables end positions #915
• Fix no-duplicate-dollar-variables end positions #916
• Fix no-duplicate-mixins end positions #917
• Fix no-global-function-names end positions #918
• Fix operator-no-newline-after end positions #936
• Fix operator-no-newline-before end positions #937
• Fix operator-no-unspaced end positions #938
• Fix partial-no-import end positions #919
• Fix percent-placeholder-pattern end positions #920
• property-no-unknown already resolved
• Fix selector-nest-combinators end positions #921
• Fix selector-no-redundant-nesting-selector end positions #922
• Fix selector-no-union-class-name end positions #923

I wish this list would help many contributions!

[ybiquitous]

I've made one PR #655 to make subsequent PRs easier.

[kristerkari]

@ybiquitous Thanks a ton for the PRs. It really is a lot of work for you to migrate the rules :)

[ybiquitous]

Yeah, I've done more than half of the rules for now. I'll complete this issue within a few weeks. 👌🏼

[ybiquitous]

I've created Pull Requests for all the rules! See the updated tasklist in #652 (comment).

[kristerkari]

Thanks again! All merged now. :)

[ybiquitous]

Thanks for merging all! I'm closing this issue.