Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore options to no-duplicate-dollar-variables #256

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Add ignore options to no-duplicate-dollar-variables #256

merged 1 commit into from
Jul 21, 2018

Conversation

kristerkari
Copy link
Collaborator

Closes #244

@kristerkari kristerkari mentioned this pull request Jun 16, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.139% when pulling 3a691a5 on feature/no-duplicate-dollar-variables-ignore-options into 69a4c62 on master.

alexander-akait
alexander-akait reviewed Jun 16, 2018
View reviewed changes
Copy link
Contributor

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good 👍

@kristerkari kristerkari merged commit 860d730 into master Jul 21, 2018
@kristerkari kristerkari deleted the feature/no-duplicate-dollar-variables-ignore-options branch July 21, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristerkari @coveralls @alexander-akait