Switch to xo for linting #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
May 2, 2023
|
|
||
| const ruleName = namespace("at-if-no-null"); | ||
|
|
||
| const messages = utils.ruleMessages(ruleName, { | ||
| equals_null: "Expected @if not statement rather than @if statement == null", | ||
| not_equals_null: "Expected @if statement rather than @if statement != null" | ||
| equalsNull: "Expected @if not statement rather than @if statement == null", |
There was a problem hiding this comment.
AFAICT these are only used in tests, but let me know if the change is considered a breaking one, and I'll revert and add a TODO
XhmikosR
commented
May 2, 2023
| @@ -32,20 +32,20 @@ function rule(expectation) { | |||
| } | |||
|
|
|||
| // If rule != null and (expr), skip | |||
| if (atrule.params.match(/.* != null and .*/)) { | |||
| if (/.* != null and .*/.test(atrule.params)) { | |||
There was a problem hiding this comment.
I kept the test changes as a separate patch; let me know if you want me to drop them.
XhmikosR
commented
May 5, 2023
| @@ -42,7 +42,7 @@ rule.messages = messages; | |||
| rule.meta = meta; | |||
|
|
|||
| function isLoudComment(comment) { | |||
| const regex = new RegExp(/^[ \t\n]*\/\*/); | |||
| const regex = /^[ \t\n]*\/\*/; | |||
There was a problem hiding this comment.
This needs a confirmation just in case
XhmikosR
force-pushed
the
xmr/xo
branch
2 times, most recently
from
4cfd043
to
3e1b9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will conflict with #815, I'll rebase if needed.