Fix function-no-unknown false negatives for functions with namespace
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Stylelint 15.8.0, the built-in `function-no-unknown` rule has ignored SCSS functions with namespace.
For example, the following code unexpectedly passes with Stylelint 15.8.0:
```scss
a { color: color.unknown(#fff); }
```
Notes:
- This change keeps backward compatibility. This means not to change `peerDependencies.stylelint` in `package.json`.
- This change may bring performance penalty to keep backward compatibility.
- Run `npm i 'stylelint@^15.8.0' && npm t` to test this change with newer versions of Stylelint.
See also:
- https://github.com/stylelint/stylelint/releases/tag/15.8.0
- stylelint/stylelint#6921
|
Thanks a lot! This is actually good to get fixed since it has been broken for quite a while already :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Stylelint 15.8.0, the built-in
function-no-unknownrule has ignored SCSS functions with namespace.For example, the following code unexpectedly passes with Stylelint 15.8.0:
Notes:
peerDependencies.stylelintinpackage.json.npm i 'stylelint@^15.8.0' && npm tto test this change with newer versions of Stylelint.See also:
function-no-unknownfalse positives for SCSS functions with namespace stylelint/stylelint#6921This Pull Request should resolve the CI failure in PR #873.