feat: Add jest as an ESLint environment and switch tests from tape to jest
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
requested changes
Nov 20, 2016
| t.ok(isObject(config.env), "env is object") | ||
| t.ok(isObject(config.rules), "rules is object") | ||
| t.end() | ||
| it("Test basic properties of config", function () { |
| }) | ||
|
|
||
| test("load config in eslint to validate all rule syntax is correct", function (t) { | ||
| it("Load config in ESLint to validate all rule syntax is correct", function () { |
|
Good stuff thanks. Two minor requests. I don't think we need to worry about the loss of the individual assertions descriptions here as they are kind of redundant. |
|
done 😄 |
jeddy3
approved these changes
Nov 21, 2016
|
Thanks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be released as a minor semver update, i.e.
5.1.0:• Adding
jestas an additional environment variable should not cause CI failures