-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide TypeScript definition and JSDoc #40
Conversation
```shell npm i -D typescript @types/jest ```
Excellent stuff. The I suggest we remove the |
@jeddy3 Thanks for explaining the background. I agree with removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
LGTM - feel free to merge.
Manually tested with stylelint-scales
(a plugin pack I maintain).
Shall we add three changelog entries after merge?:
|
Can you please merge, update the changelog, and release a new version if possible? |
Wait, I find a typo. I try fixing it. |
Can do. |
Released in 5.0.0 |
Thank you so much! 🎉 |
Closes #15
Ref: stylelint/stylelint#5725
This change aims to improve the developer experience when using the
testRule()
utility.This additionally installs the following package:
Also, this supports
endLine
andendColumn
. See stylelint/stylelint#5725To-do
stylelint/stylelint
repo.