Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Bump remark-cli from 8.0.1 to 9.0.0 #70

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 15, 2020

Bumps remark-cli from 8.0.1 to 9.0.0.

Release notes

Sourced from remark-cli's releases.

remark-cli@9.0.0

See remark@13.0.0

remark-cli@9.0.0-alpha.1

See [GH-536](https://github.com/remarkjs/remark/issues/536)

remark-cli@9.0.0-alpha.0

See [GH-536](https://github.com/remarkjs/remark/issues/536)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the pr: dependencies relates to dependencies label Oct 15, 2020
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/remark-cli-9.0.0 branch from 4b2b25d to 5fa021a Compare January 4, 2021 10:07
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/remark-cli-9.0.0 branch from 5fa021a to b015ebf Compare January 4, 2021 10:27
@mattxwang
Copy link
Member

Just reading through the changelog here for remark version 13; it looks very exciting! However, there is one pretty significant change: by default, GitHub Flavored Markdown (GFM) is no longer supported, and now needs to be brought in with an extension (see Migration in the change notes).

That being said, we don't really lint that many markdown files with this anyways, and this does already pass our CI tests. Before we merge though, we may want to decide if we want to add this GFM plugin, and/or update the @stylelint/remark-reset repo.

Any thoughts? I'm not particularly up-to-date with the use-case here, so I might be missing something!

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

Before we merge though, we may want to decide if we want to add this GFM plugin, and/or update the @stylelint/remark-reset repo.

Let's roll with Commonmark as I can't think of an occasion where we've written markdown tables in our docs.

I think we can merge this and then update @stylelint/remark-reset to remark 9.

@mattxwang
Copy link
Member

Sounds good, thanks for the quick response @jeddy3! I can merge this and update the relevant dependencies in the @stylelint/remark-preset package then.

@mattxwang mattxwang merged commit 61925a2 into master Feb 4, 2021
@mattxwang mattxwang deleted the dependabot/npm_and_yarn/remark-cli-9.0.0 branch February 4, 2021 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: dependencies relates to dependencies
2 participants