Skip to content

Commit

Permalink
Prepare 14.0.0 (#204)
Browse files Browse the repository at this point in the history
  • Loading branch information
ybiquitous committed Dec 8, 2023
1 parent d0c62e5 commit f829725
Show file tree
Hide file tree
Showing 7 changed files with 1,188 additions and 4,200 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ on:
branches:
- main
pull_request:
branches:
- '**'

jobs:
lint:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 14.0.0

- Removed: `stylelint` less than `16.0.0` from peer dependencies.
- Removed: Node.js less than `18.12.0` support.

## 13.0.0

- Removed: `stylelint` less than `15.10.0` from peer dependencies.
Expand Down
12 changes: 7 additions & 5 deletions __tests__/engines.test.js → __tests__/engines.test.mjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
'use strict';
import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import { execFileSync } from 'node:child_process';
import { readFileSync } from 'node:fs';

const { execFileSync } = require('child_process');
const pkg = require('../package.json');
const pkg = JSON.parse(readFileSync(new URL('../package.json', import.meta.url), 'utf8'));

describe('engines.node', () => {
it("is the same as stylelint's one", () => {
Expand All @@ -18,7 +20,7 @@ describe('engines.node', () => {
// `^x.y.z` range can return multiple versions.
const nodeVersions = Array.isArray(nodeVersion) ? [...new Set(nodeVersion)] : [nodeVersion];

expect(nodeVersions).toHaveLength(1);
expect(nodeVersions).toContain(pkg.engines.node);
assert.equal(nodeVersions.length, 1);
assert.ok(nodeVersions.includes(pkg.engines.node));
});
});
81 changes: 0 additions & 81 deletions __tests__/index.test.js

This file was deleted.

86 changes: 86 additions & 0 deletions __tests__/index.test.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
import { describe, it, beforeEach } from 'node:test';
import assert from 'node:assert/strict';
import { readFileSync } from 'node:fs';

import stylelint from 'stylelint';
import config from '../index.js';

const validCss = readFileSync('./__tests__/valid.css', 'utf-8');
const invalidCss = readFileSync('./__tests__/invalid.css', 'utf-8');

describe('flags no warnings with valid css', () => {
let result;

beforeEach(async () => {
result = await stylelint.lint({
code: validCss,
config,
});
});

it('has no errors', () => {
assert.equal(result.errored, false);
});

it('flags no warnings', () => {
assert.equal(result.results[0].warnings.length, 0);
});
});

describe('flags warnings with invalid css', () => {
let result;

beforeEach(async () => {
result = await stylelint.lint({
code: invalidCss,
config,
});
});

it('includes an error', () => {
assert.equal(result.errored, true);
});

it('flags one warning', () => {
assert.equal(result.results[0].warnings.length, 1);
});

it('corrects warning text', () => {
assert.equal(
result.results[0].warnings[0].text,
'Unexpected unknown type selector "madeup" (selector-type-no-unknown)',
);
});

it('corrects rule flagged', () => {
assert.equal(result.results[0].warnings[0].rule, 'selector-type-no-unknown');
});

it('corrects severity flagged', () => {
assert.equal(result.results[0].warnings[0].severity, 'error');
});

it('corrects line number', () => {
assert.equal(result.results[0].warnings[0].line, 1);
});

it('corrects column number', () => {
assert.equal(result.results[0].warnings[0].column, 1);
});
});

describe('deprecated rules are excluded', () => {
const ruleNames = Object.keys(config.rules);

it('is not empty', () => {
assert.ok(ruleNames.length > 0);
});

for (const ruleName of ruleNames) {
it(`${ruleName}`, async () => {
const rule = await stylelint.rules[ruleName];

assert.ok(!rule.meta.deprecated);
});
}
});

0 comments on commit f829725

Please sign in to comment.