Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engines.test.js for multiple potential versions #197

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #196 (comment)

Is there anything in the PR that needs further explanation?

npm view can return an array or a single string depending on published versions.

See below:

$ npm view --json stylelint@^15.9.0 engines.node
[
  "^14.13.1 || >=16.0.0",
  "^14.13.1 || >=16.0.0"
]
$ npm view --json stylelint@^15.10.0 engines.node
"^14.13.1 || >=16.0.0"

`npm view` can return an array or a single string depending on published versions.

See below:

```console
$ npm view --json stylelint@^15.9.0 engines.node
[
  "^14.13.1 || >=16.0.0",
  "^14.13.1 || >=16.0.0"
]
```

```console
$ npm view --json stylelint@^15.10.0 engines.node
"^14.13.1 || >=16.0.0"
```
@ybiquitous ybiquitous mentioned this pull request Jul 4, 2023
@ybiquitous ybiquitous marked this pull request as ready for review July 4, 2023 23:29
ybiquitous added a commit to stylelint/stylelint-config-standard that referenced this pull request Jul 5, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for digging into it.

@ybiquitous ybiquitous merged commit 6e5406e into main Jul 5, 2023
7 checks passed
@ybiquitous ybiquitous deleted the fix-engines-test branch July 5, 2023 12:32
ybiquitous added a commit to stylelint/stylelint-config-standard that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants