Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 5.0.0 #98

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Prepare 5.0.0 #98

merged 1 commit into from
Apr 24, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 23, 2021

Which issue, if any, is this issue related to?

None.

mattxwang
mattxwang approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, LGTM.

@ybiquitous
Copy link
Member

Like stylelint/stylelint-config-standard#178, will you change index.js and package.json in this PR?

@jeddy3
Copy link
Member Author

jeddy3 commented Apr 24, 2021

Like stylelint/stylelint-config-standard#178, will you change index.js and package.json in this PR?

That's in #97

ybiquitous
ybiquitous approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed it. LGTM 👍🏼

@jeddy3 jeddy3 merged commit d4add7a into master Apr 24, 2021
@jeddy3 jeddy3 deleted the prepare-5 branch April 24, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeddy3 @ybiquitous @mattxwang