Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint-config-stylelint #119

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Update eslint-config-stylelint #119

merged 1 commit into from
Oct 20, 2018

Conversation

hudochenkov
Copy link
Member

No description provided.

jeddy3
jeddy3 approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI, I believe you can work in the greenkeeper branches/PRs rather than creating new ones.

@ntwb
Copy link
Member

ntwb commented Oct 20, 2018

FYI, I believe you can work in the greenkeeper branches/PRs rather than creating new ones.

Indeed, I usually push directly into the Greenkeeper branch for the flow-bin change PRs

@hudochenkov
Copy link
Member Author

Sorry, I get carried away with Hacktoberfest.

@hudochenkov hudochenkov merged commit 456eec3 into master Oct 20, 2018
@hudochenkov hudochenkov deleted the update-eslint-config-stylelint branch October 20, 2018 09:24
@ntwb
Copy link
Member

ntwb commented Oct 21, 2018

Sorry, I get carried away with Hacktoberfest.

I should do the same, this year it's only the first 50,000 that will get a shirt ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hudochenkov @ntwb @jeddy3