Fix selector-type-no-unknown false positives for experimental and d…

…eprecated HTML tags (#7612)
stylelint · Apr 18, 2024 · 1368299 · 1368299
1 parent d06a41e
commit 1368299
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 14 deletions.
diff --git a/.changeset/flat-bananas-hug.md b/.changeset/flat-bananas-hug.md
@@ -0,0 +1,5 @@
+---
+"stylelint": patch
+---
+
+Fixed: `selector-type-no-unknown` false positives for experimental and deprecated HTML tags
diff --git a/lib/reference/selectors.cjs b/lib/reference/selectors.cjs
@@ -10,21 +10,25 @@ const deprecatedHtmlTypeSelectors = new Set([
 	'applet',
 	'basefont',
 	'big',
+	'bgsound',
 	'blink',
 	'center',
 	'content',
 	'dir',
 	'font',
 	'frame',
 	'frameset',
-	'hgroup',
 	'isindex',
 	'keygen',
 	'listing',
 	'marquee',
+	'multicol',
+	'nextid',
 	'nobr',
 	'noembed',
+	'noframes',
 	'plaintext',
+	'param',
 	'spacer',
 	'strike',
 	'tt',
@@ -35,7 +39,13 @@ const deprecatedHtmlTypeSelectors = new Set([
 /** @type {Set<string>} */
 const standardHtmlTypeSelectors = new Set(htmlTags);
 
-const htmlTypeSelectors = uniteSets(deprecatedHtmlTypeSelectors, standardHtmlTypeSelectors);
+const experimentalHtmlTypeSelectors = new Set(['fencedframe', 'listbox', 'portal', 'selectlist']);
+
+const htmlTypeSelectors = uniteSets(
+	deprecatedHtmlTypeSelectors,
+	standardHtmlTypeSelectors,
+	experimentalHtmlTypeSelectors,
+);
 
 const mixedCaseSvgTypeSelectors = new Set([
 	'altGlyph',

diff --git a/lib/reference/selectors.mjs b/lib/reference/selectors.mjs
@@ -7,21 +7,25 @@ const deprecatedHtmlTypeSelectors = new Set([
 	'applet',
 	'basefont',
 	'big',
+	'bgsound',
 	'blink',
 	'center',
 	'content',
 	'dir',
 	'font',
 	'frame',
 	'frameset',
-	'hgroup',
 	'isindex',
 	'keygen',
 	'listing',
 	'marquee',
+	'multicol',
+	'nextid',
 	'nobr',
 	'noembed',
+	'noframes',
 	'plaintext',
+	'param',
 	'spacer',
 	'strike',
 	'tt',
@@ -32,7 +36,13 @@ const deprecatedHtmlTypeSelectors = new Set([
 /** @type {Set<string>} */
 const standardHtmlTypeSelectors = new Set(htmlTags);
 
-export const htmlTypeSelectors = uniteSets(deprecatedHtmlTypeSelectors, standardHtmlTypeSelectors);
+const experimentalHtmlTypeSelectors = new Set(['fencedframe', 'listbox', 'portal', 'selectlist']);
+
+export const htmlTypeSelectors = uniteSets(
+	deprecatedHtmlTypeSelectors,
+	standardHtmlTypeSelectors,
+	experimentalHtmlTypeSelectors,
+);
 
 export const mixedCaseSvgTypeSelectors = new Set([
 	'altGlyph',

diff --git a/lib/rules/selector-type-no-unknown/__tests__/index.mjs b/lib/rules/selector-type-no-unknown/__tests__/index.mjs
@@ -84,6 +84,9 @@ testRule({
 			code: 'circle {}',
 			description: 'svg tags',
 		},
+		{
+			code: 'fencedframe, listbox, portal, selectlist {}',
+		},
 		{
 			code: 'foreignObject {}',
 			description: 'case-sensitive svg tags',

diff --git a/lib/utils/isCustomElement.cjs b/lib/utils/isCustomElement.cjs
@@ -3,7 +3,6 @@
 'use strict';
 
 const svgTags = require('svg-tags');
-const selectors = require('../reference/selectors.cjs');
 const mathMLTags = require('./mathMLTags.cjs');
 
 /**
@@ -31,10 +30,6 @@ function isCustomElement(selector) {
 		return false;
 	}
 
-	if (selectors.htmlTypeSelectors.has(selectorLowerCase)) {
-		return false;
-	}
-
 	if (mathMLTags.includes(selectorLowerCase)) {
 		return false;
 	}

diff --git a/lib/utils/isCustomElement.mjs b/lib/utils/isCustomElement.mjs
@@ -1,6 +1,5 @@
 import svgTags from 'svg-tags';
 
-import { htmlTypeSelectors } from '../reference/selectors.mjs';
 import mathMLTags from './mathMLTags.mjs';
 
 /**
@@ -28,10 +27,6 @@ export default function isCustomElement(selector) {
 		return false;
 	}
 
-	if (htmlTypeSelectors.has(selectorLowerCase)) {
-		return false;
-	}
-
 	if (mathMLTags.includes(selectorLowerCase)) {
 		return false;
 	}