Use regex.test() when we want only to check for a boolean (#4507)

stylelint · Jan 2, 2020 · 31dd8d4 · 31dd8d4
1 parent 8872b76
commit 31dd8d4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/rules/keyframes-name-pattern/index.js b/lib/rules/keyframes-name-pattern/index.js
@@ -28,7 +28,7 @@ const rule = function(pattern) {
 		root.walkAtRules(/keyframes/i, (keyframesNode) => {
 			const value = keyframesNode.params;
 
-			if (value.match(regex)) {
+			if (regex.test(value)) {
 				return;
 			}
 

diff --git a/lib/rules/selector-list-comma-newline-after/index.js b/lib/rules/selector-list-comma-newline-after/index.js
@@ -51,12 +51,12 @@ const rule = function(expectation, options, context) {
 
 					// If there's a // comment, that means there has to be a newline
 					// ending the comment so we're fine
-					if (nextChars.match(/^\s+\/\//)) {
+					if (/^\s+\/\//.test(nextChars)) {
 						return;
 					}
 
 					// If there are spaces and then a comment begins, look for the newline
-					const indextoCheckAfter = nextChars.match(/^\s+\/\*/)
+					const indextoCheckAfter = /^\s+\/\*/.test(nextChars)
 						? selector.indexOf('*/', match.endIndex) + 1
 						: match.startIndex;
 

diff --git a/lib/rules/value-list-comma-newline-after/index.js b/lib/rules/value-list-comma-newline-after/index.js
@@ -56,12 +56,12 @@ const rule = function(expectation, options, context) {
 
 				// If there's a // comment, that means there has to be a newline
 				// ending the comment so we're fine
-				if (nextChars.match(/^[ \t]*\/\//)) {
+				if (/^[ \t]*\/\//.test(nextChars)) {
 					return false;
 				}
 
 				// If there are spaces and then a comment begins, look for the newline
-				return nextChars.match(/^[ \t]*\/\*/)
+				return /^[ \t]*\/\*/.test(nextChars)
 					? declString.indexOf('*/', match.endIndex) + 1
 					: match.startIndex;
 			},