Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selector-type-no-unknown does not like keyframes with decimal value #1513

Closed
nikolas6 opened this issue Jun 23, 2016 · 2 comments
Closed

selector-type-no-unknown does not like keyframes with decimal value #1513

nikolas6 opened this issue Jun 23, 2016 · 2 comments
Assignees
@jeddy3
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@nikolas6
Copy link

Stylelint 6.7.0 complains when keyframe animation has decimal value like "50.001%".

Sample:

@keyframes loadingAnimation1 {
  0% {
    transform: translate3d(0, 0, 0);
  }
  50% {
    transform: translate3d(100%, 0, 0);
  }
  50.001% {
    transform: translate3d(-100%, 0, 0);
  }
  100% {
    transform: translate3d(0, 0, 0);
  }
}
@nikolas6 nikolas6 mentioned this issue Jun 23, 2016
Closed
@jeddy3 jeddy3 added status: wip is being worked on by someone type: bug a problem with a feature or rule labels Jun 23, 2016
@jeddy3 jeddy3 self-assigned this Jun 23, 2016
@jeddy3 jeddy3 mentioned this issue Jun 23, 2016
Merged
@jeddy3
Copy link
Member

jeddy3 commented Jun 23, 2016

@nikolas6 I've just pushed up a pending PR for this. Hopefully we can get a patch release out soon.

P.S. Please use the template when creating new issues as it helps us resolve these types of bugs a little quicker.

@nikolas6
Copy link
Author

Thanks @jeddy3 :)
Noted on the template. My first time reporting issues here.

@pete-the-pete pete-the-pete mentioned this issue Jul 11, 2016
Merged
traviskaufman added a commit to traviskaufman/stylelint that referenced this issue Jul 15, 2016
@traviskaufman
Ignore fractional keyframes in selector-class-pattern
cc33dc1 
Relates to stylelint#1583, stylelint#1513. `selector-class-pattern` was yielding false positive
for fractional keyframes. This commit fixes this issue, essentially copying
the work done in PR stylelint#1514.
@traviskaufman traviskaufman mentioned this issue Jul 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeddy3 jeddy3

Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeddy3 @nikolas6