New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rules: selector-combinator-before and -after #20

Closed

davidtheclark opened this issue May 8, 2015 · 4 comments

Assignees

Labels

status: wip type: enhancement

Contributor

davidtheclark commented May 8, 2015

I will work on these very soon.

Member

jeddy3 commented May 8, 2015

I'm excited to see this one! Will you build it on top of your list-selectors work?

MoOx assigned davidtheclark

Contributor Author

davidtheclark commented May 10, 2015

Does anybody anticipate a need to allow for anything other than a single space before or after?

If not, should we change this rule to selector-combinator-space-before and -after and make it a simple true/false?

I have the same thought about a bunch of other whitespace-related rules (e.g. #36), where the suggestion in #1 is that they would be open-ended and users would enter arbitrary characters but the tool and code would be significantly simpler if we just accommodated what might be the only actual use-case, which is requiring or rejecting single spaces in those places.

davidtheclark mentioned this issue

Defining whitespace rules #40

Closed

Contributor Author

davidtheclark commented May 11, 2015

Bypass this comment and please read #40 and share you thoughts there.

MoOx added status: wip type: enhancement labels

Contributor Author

davidtheclark commented May 13, 2015

Done in 64f72fe as selector-combinator-space

davidtheclark closed this as completed

ntwb pushed a commit that referenced this issue


          Update log-symbols to the latest version 🚀 (#4038)

36ede74

## The dependency [log-symbols](https://github.com/sindresorhus/log-symbols) was updated from `2.2.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<p>Breaking:</p>
<ul>
<li>Require Node.js 8  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/log-symbols/commit/e1542f5ce4b2623f4ec56d226212d19e37de0df8/hovercard" href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/e1542f5ce4b2623f4ec56d226212d19e37de0df8"><tt>e1542f5</tt></a></li>
</ul>
<p>Enhancements:</p>
<ul>
<li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432864405" data-permission-text="Issue title is private" data-url="sindresorhus/log-symbols#20" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/log-symbols/pull/20/hovercard" href="https://urls.greenkeeper.io/sindresorhus/log-symbols/pull/20">#20</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/log-symbols/commit/95dd49155fdac1cd32e5109847e9b7d2c5278063/hovercard" href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/95dd49155fdac1cd32e5109847e9b7d2c5278063"><tt>95dd491</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/log-symbols/compare/v2.2.0...v3.0.0"><tt>v2.2.0...v3.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 5 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/1f4ac6ef31cb4c7c4c4c67b7d6f9db712d4c0186"><code>1f4ac6e</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/e1542f5ce4b2623f4ec56d226212d19e37de0df8"><code>e1542f5</code></a> <code>Require Node.js 8</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/95dd49155fdac1cd32e5109847e9b7d2c5278063"><code>95dd491</code></a> <code>Add TypeScript definition (#20)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/8b40bbb50575f70ec2eec4674f943b266736e372"><code>8b40bbb</code></a> <code>Require Node.js 6</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/commit/e70127f87395bad439cbfbfc04c8f1cdf822b285"><code>e70127f</code></a> <code>Add Ruby port to related section (#19)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/log-symbols/compare/029dbb35f81c0e8471a4fa1fcf014af416d3230d...1f4ac6ef31cb4c7c4c4c67b7d6f9db712d4c0186">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴

snyk-bot mentioned this issue

[Snyk] Upgrade balanced-match from 0.2.1 to 0.4.2 chriswrightdesign/stylelint#2

Open

snyk-bot mentioned this issue

[Snyk] Fix for 1 vulnerabilities Bhanditz/stylelint#7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment