Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-family-no-duplicate-names false positive #2312

Closed
oliviertassinari opened this issue Feb 1, 2017 · 3 comments
Closed

font-family-no-duplicate-names false positive #2312

oliviertassinari opened this issue Feb 1, 2017 · 3 comments

Comments

@oliviertassinari
Copy link

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

While running that tool against normalize.css source code, I have noticed a false positive.

Which rule, if any, is this issue related to?

It's affecting the font-family-no-duplicate-names rule.

What CSS is needed to reproduce this issue?

/**
 * 1. Correct the inheritance and scaling of font size in all browsers.
 * 2. Correct the odd `em` font sizing in all browsers.
 */

code,
kbd,
pre,
samp {
  font-family: monospace, monospace; /* 1 */
}

What stylelint configuration is needed to reproduce this issue?

module.exports = {
  extends: 'stylelint-config-standard',
  plugins: [
    'stylelint-declaration-use-variable',
  ],
};

Which version of stylelint are you using?

7.7.1

What did you expect to happen?

No warnings to be flagged.
That duplication seems still required. necolas/normalize.css#654.
I would understand if you decide no to fix the issue. That fix is a decade old.
I'm not sure that it's still relevant.

What actually happened (e.g. what warnings or errors you are getting)?

The following warnings were flagged:

normalize.scss
 224:27  ✖  Unexpected duplicate name monospace   font-family-no-duplicate-names
@davidtheclark
Copy link
Contributor

Definitely not a "false positive", right? Because it's working exactly as expected? What you have there is a weird exception. I think /* stylelint-disable */ comments are the best way to handle such weird exceptions.

@jeddy3
Copy link
Member

jeddy3 commented Feb 1, 2017

@oliviertassinari Thanks for using the template.

Dupe of #2086.

Either use /* stylelint-disable */ or consider contributing option.

@jeddy3 jeddy3 closed this as completed Feb 1, 2017
@oliviertassinari
Copy link
Author

Thanks for the quick answer. I'm late to the party.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants