Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for font-face in font-family-no-missing-generic-family-keyword #3034

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Fix false positives for font-face in font-family-no-missing-generic-family-keyword #3034

merged 1 commit into from
Nov 27, 2017

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Nov 26, 2017

Closes #3033

hudochenkov
hudochenkov approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

ntwb
ntwb approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeddy3 jeddy3 merged commit 7db5f1d into master Nov 27, 2017
@jeddy3 jeddy3 deleted the issue-3033 branch November 27, 2017 08:48
@jeddy3
Copy link
Member Author

jeddy3 commented Nov 27, 2017

  • Fixed: font-family-no-missing-generic-family-keyword false positives for at-font-face (#3034).

@modosc
Copy link
Member

modosc commented Nov 27, 2017

hah, just came here to file this. thanks!

@dependencies dependencies bot mentioned this pull request Dec 5, 2017
Merged
@dependencies dependencies bot mentioned this pull request Dec 18, 2017
Open
@dependencies dependencies bot mentioned this pull request Dec 27, 2017
Merged
This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeddy3 @modosc @hudochenkov @ntwb