Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["next-sibling"] to selector-max-type #3757

Closed
ssivanatarajan opened this issue Oct 29, 2018 · 1 comment
Closed

Add ignore: ["next-sibling"] to selector-max-type #3757

ssivanatarajan opened this issue Oct 29, 2018 · 1 comment
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: new option a new option for an existing rule

Comments

@ssivanatarajan
Copy link
Contributor

What is the problem you're trying to solve?

Need Combinators as ignore option for "selector-max-type" rule.

What solution would you like to see?

A new option should ignore "Subsequent-sibling combinator " and "Next-sibling combinator"
in "selector-max-type" rule.

The rule should ignore below css
#userSelVal + span{}
#userSelVal > span{}

@jeddy3
Copy link
Member

jeddy3 commented Oct 29, 2018

@ssivanatarajan Thanks for the suggestion.

#userSelVal + span{}

Yes, an ignore: ["next-sibling"] option will work here (ref).

Please consider contributing this option. There's a section in the Developer Guide on how to get started.

#userSelVal > span{}

You can use the exisiting ignore: ["child"] secondary option for this.

If you also need an option for subsequent-sibling combinator (aka ~), please create a separate issue.

@jeddy3 jeddy3 changed the title Add Combinators option for ignore in selector-max-type rule Add ignore: ["next-sibling"] to selector-max-type Oct 29, 2018
@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: new option a new option for an existing rule good first issue is good for newcomers labels Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: new option a new option for an existing rule
Development

No branches or pull requests

2 participants