-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore: ["next-sibling"] to selector-max-type #3832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliyaZelenko Thanks!
I've requested a few changes (some using the new "Suggested change" feature).
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
This is my first time when I've done so much in someone else's repository. It's good that everything went well, I think in the future I will still do something for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. It's looking good!
I've made three very minor doc tweak suggestions:
- adding backticks around the heading
- removing two empty lines
After that, I think it'll look good to me.
It's good that everything went well, I think in the future I will still do something for you.
Thanks for your contribution! It's appreciated :)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Does anyone have the time to provide a second review on this? |
@iliyaZelenko Sorry to trouble you once last time, but would you be able to resolve the conflicts so we can merge this? |
No problem, it seems nothing complicated. The tests did not pass, I will try to solve it in the near future. |
I think we're simply missing the "next-sibling" option in the validator. It looks like it got removed when resolving the conflicts. Adding it back in should see the tests passing again. See:
|
@jeddy3 You are right, thank you, did not notice. Everything is working. |
Changelog entry added:
|
Closes #3757
"No, it's self explanatory."