Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor standalone-cache.test.js #3786

Closed
hudochenkov opened this issue Nov 8, 2018 · 0 comments · Fixed by #3940
Closed

Refactor standalone-cache.test.js #3786

hudochenkov opened this issue Nov 8, 2018 · 0 comments · Fixed by #3940
Labels
status: ready to implement is ready to be worked on by someone type: tests an improvement to testing

Comments

@hudochenkov
Copy link
Member

In standalone-cache.test.js we rely on an implementation detail of a dependency of a dependency of a dependency, which leads to problems like this one: #3779 (comment).

We should not do this.

Related issues:

eslint/eslint#11062
jaredwray/flat-cache#22
@hudochenkov hudochenkov mentioned this issue Nov 8, 2018
Closed
4 tasks
@hudochenkov hudochenkov added status: ready to implement is ready to be worked on by someone type: tests an improvement to testing type: infrastructure an improvement to devops labels Nov 8, 2018
@jeddy3 jeddy3 removed the type: infrastructure an improvement to devops label Nov 13, 2018
@hudochenkov hudochenkov mentioned this issue Jan 9, 2019
Closed
@Teamop Teamop mentioned this issue Jan 17, 2019
Merged
@Teamop Teamop mentioned this issue Feb 5, 2019
Merged
@ntwb ntwb closed this as completed in #3940 Feb 5, 2019
ntwb pushed a commit that referenced this issue Feb 5, 2019
@Teamop @ntwb
Refactor standalone-cache.test.js to avoid relying on 'flatted' (#3940)
0f5474d 
<!---
Please read the following. Pull requests that do not adhere to these guidelines will be closed.

Each pull request must, with the exception of minor documentation fixes, be associated with an open issue. If a corresponding issue does not exist please stop. Instead, create an issue so we can discuss the change first.

If there is an associated open issue, then the next step is to make sure you've read the relevant developer guide:

- Creating a new rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#creating-a-new-rule

- Adding an option to an existing rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#adding-an-option-to-an-existing-rule

- Fixing a bug in an existing rule: https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/rules.md#fixing-a-bug-in-an-existing-rule

Once you've done that, then please continue by answering these two questions:  -->

> Which issue, if any, is this issue related to?

Closes #3786

> Is there anything in the PR that needs further explanation?

Use `file-entry-cache#createFromFile` to create another instance of the cache, so that we can access to the cache without relying on the `flatted` which is the dependency of `file-entry-cache`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ready to implement is ready to be worked on by someone type: tests an improvement to testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor standalone-cache.test.js to avoid relying on 'flatted' Teamop/stylelint
2 participants
@hudochenkov @jeddy3