Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated syntax options #4007

Closed
hudochenkov opened this Issue Apr 3, 2019 · 2 comments

Comments

3 participants
@hudochenkov
Copy link
Member

commented Apr 3, 2019

Options styled, and jsx for syntax were replaced with css-in-js in #3872.

We should remove them in the next major release.

We didn't show any deprecation notice. We can't release release new patch version with deprecation notice without making a special branch for release. Because master has breaking changes already.

It's should be fine. We'll address this change in release notes.

@hudochenkov hudochenkov added this to the future-major milestone Apr 3, 2019

@jeddy3

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

We'll address this change in release notes.

SGTM. I think we can just remove the old styled and jsx options for 10.0.0.

@ntwb ntwb closed this in #4009 Apr 8, 2019

ntwb added a commit that referenced this issue Apr 8, 2019

Remove `styled` and `jsx` syntax options (#4009)
> Which issue, if any, is this issue related to?

Closes #4007

> Is there anything in the PR that needs further explanation?

No, it's self explanatory.
@ntwb

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Changelog: bfbf462

Removed: styled and jsx syntax options that were replaced with css-in-js in v9.10.0 (#4007).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.