-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix open handle in tests #4596
Labels
status: ready to implement
is ready to be worked on by someone
type: tests
an improvement to testing
Comments
jeddy3
added
status: ready to implement
is ready to be worked on by someone
type: tests
an improvement to testing
labels
Feb 13, 2020
hudochenkov
added a commit
that referenced
this issue
Feb 13, 2020
hudochenkov
added a commit
that referenced
this issue
Feb 13, 2020
hudochenkov
added a commit
that referenced
this issue
Feb 13, 2020
jeddy3
pushed a commit
that referenced
this issue
Feb 14, 2020
jeddy3
pushed a commit
that referenced
this issue
Feb 14, 2020
@jeddy3 You might want to try something like this
|
@exoer Thanks for the suggestion. @hudochenkov refactored these tests in #4601 and I believe the issue was resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: ready to implement
is ready to be worked on by someone
type: tests
an improvement to testing
I got this while running our tests:
Running coverage on untested files...A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --runInBand --detectOpenHandles to find leaks.
And the following:
Returns:
The text was updated successfully, but these errors were encountered: