Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 15.10.0 #7038

Closed
7 tasks done
mattxwang opened this issue Jul 3, 2023 · 18 comments
Closed
7 tasks done

Release 15.10.0 #7038

mattxwang opened this issue Jul 3, 2023 · 18 comments
Labels
status: wip is being worked on by someone

Comments

@mattxwang
Copy link
Member

mattxwang commented Jul 3, 2023

  • stylelint release
  • stylelint-config-recommended update
  • stylelint-config-standard update
  • stylelint.io update
  • stylelint-demo check
  • tweet
  • parser tweet

"Under the hood, we've replaced our media query parser with @romainmenke's more modern and spec-compliant one. If you're a plugin author targeting media queries, we recommend using this parser too: https://www.npmjs.com/package/@csstools/media-query-list-parser"

We've been releasing quite frequently recently, so this issue is more of a suggestion. It's motivated from the length of #6974, the changelog for a new version -- it's quite long, and I'm a bit wary of overwhelming users with the v16 change. Happy to also just punt all of these changes for v16!

Pending PRs that might be appropriate:

(do we want to collapse all of the performance PR messages into a handful?)

I'm happy to do as much of the release process as possible (I believe I can now also send the Tweet!).

@mattxwang mattxwang added the status: needs discussion triage needs further discussion label Jul 3, 2023
@jeddy3
Copy link
Member

jeddy3 commented Jul 3, 2023

Yes, we'll want to keep releasing 15.x while we ready 16.0.0

We don't need to wait on #6818. We can release after #6998 is merged.

(do we want to collapse all of the performance PR messages into a handful?)

I think it'll be fine as it is. Remember to put non-rule -related things first and alphabetically order related items, i.e. "- Fixed: inconsistent errored properties in stylelint.lint() return value (#6983) (@ybiquitous)." to the top of fixes.

I'm happy to do as much of the release process as possible (I believe I can now also send the Tweet!).

Fantastic, thank you. We've followed a consistent tweet format for a while now, which lists the changes and links to the changelog entry on the website.

@Mouvedia
Copy link
Contributor

Mouvedia commented Jul 3, 2023

Even if 15.10.0 is a psychological barrier, we can have several releases until v16 is ready to ship; I agree with @jeddy3.

@mattxwang
Copy link
Member Author

SGTM, thanks for the quick response both of you! I'll wait a bit for other contributors to chime in, but I can kickstart the release after #6998 is merged. I'll make sure to re-order the changelog as necessary.

As a quick aside, I just tried logging in to the Stylelint Twitter, which then needed me to log in to the Stylelint Gmail account. I was hit with a 2FA barrier there (I don't have access to the device that Gmail is requesting), so I may need some help there; otherwise, also happy to have someone else tweet it out!

@jeddy3
Copy link
Member

jeddy3 commented Jul 3, 2023

which then needed me to log in to the Stylelint Gmail account

Try again, please. Google flagged your login as suspicious. I've approved it so that you can log in now.

@mattxwang
Copy link
Member Author

Try again, please. Google flagged your login as suspicious. I've approved it so that you can log in now.

Thanks; I've tried again, but I'm still hitting the same 2FA prompt on logging in with the password. Any suggestions on how to best do this? Probably requires some sort of synchronous work?

@ybiquitous
Copy link
Member

I just tried Twitter login too, but I was requested email verification. I haven't encountered this before. 🤔

@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

Strange. Can you try again please, as I've just marked both login attempts as legitimate?

@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

I've turned on 2FA for both Google and Twitter. You'll find the one-time codes in the shared vault. I'm hoping this will reduce the services flagging our access attempts.

@ybiquitous
Copy link
Member

@jeddy3 Thank you. I've successfully logged in to Twitter. 👍🏼

@mattxwang
Copy link
Member Author

Thanks @jeddy3, confirming I have access to Google and Twitter as well. I'll kickstart the release since we've merged #6998!

mattxwang added a commit that referenced this issue Jul 4, 2023
@mattxwang mattxwang added status: wip is being worked on by someone and removed status: needs discussion triage needs further discussion labels Jul 4, 2023
@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

I'll kickstart the release since we've merged #6998!

Fantastic, thank you!

@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

I don't think we need to release new versions of the configs. Let's just make this release about the main package.

@mattxwang
Copy link
Member Author

Oh, gotcha, thanks for letting me know (I was about to do that 😓 ); to confirm, that means we won't add media-query-no-invalid to the recommended config?

mattxwang added a commit that referenced this issue Jul 4, 2023
Manually reordered changelog entry; ref: maintainer guide and #7038 (comment)

---------

Co-authored-by: Matthew Wang <matt@matthewwang.me>
@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

to confirm, that means we won't add media-query-no-invalid to the recommended config?

Oops, I forgot about that rule. Scratch what I said, let's release new versions. If you prep the pull requests, I can review them for you now.

@mattxwang
Copy link
Member Author

Verified that the demo flags input like @media not(min-width: 300px) {}! Going to make the two tweets now, and then can close this issue.

@mattxwang
Copy link
Member Author

Have tweeted out a 3-tweet thread: https://twitter.com/stylelint/status/1676335493620043777

(no matter how many times I forced a refresh on the main changelog, it didn't change the body of the embed saying 15.9.0. 😓 )

With that, I think we can mark this issue as complete? Thanks to @jeddy3 for reviewing all of my PRs and for everybody's hard work in this release 🥳 🎊 ❤️

@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

@mattxwang Thank you for doing the release!

@ybiquitous
Copy link
Member

@mattxwang Great work! 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone
Development

No branches or pull requests

4 participants