Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #1385

Merged
merged 7 commits into from
Jun 5, 2016
Merged

Remove deprecations #1385

merged 7 commits into from
Jun 5, 2016

Conversation

davidtheclark
Copy link
Contributor

Addresses #1310.

As you can see from commits, I've tried to:

  • Remove emptyLineBefore option for declaration-block-properties-order
  • Remove hierarchicalSelectors option from indentation
  • Remove stylelint.utils.cssWordIsVariable
  • Remove support for non-namespaced plugin rules
  • Remove deprecated options from font-family-name-quotes
  • Remove deprecated options of function-url-quotes (this plus the above = "contextual quote rule options")

I believe that addresses all the checkboxes in #1310.

Of course the big points to help check here are:

  • Documentation is updated accurately and is still helpful.
  • No still important tests were removed.

@coveralls
Copy link

coveralls commented Jun 2, 2016

Coverage Status

Coverage increased (+1.2%) to 98.232% when pulling 6dfd78c on remove-deprecations into 7e5951f on v7.

@@ -171,27 +171,6 @@ test("module providing an array of plugins", t => {
t.plan(planned)
})

test("deprecation warning for slashless plugin rule names", t => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test be replaced with a test to check for a config error? Or should the file plugin-slashless-warn-about-foo.js be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, these are good ideas. Thanks for looking closely!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In latest commit added a test, as you can see below.

@coveralls
Copy link

coveralls commented Jun 4, 2016

Coverage Status

Coverage increased (+1.2%) to 98.255% when pulling 80c9bf5 on remove-deprecations into 7e5951f on v7.

@jeddy3
Copy link
Member

jeddy3 commented Jun 5, 2016

Oh wow. Great to see this. I'm confident we're on a more sustainable trajectory with these removals.

Thanks also for bringing the contextual quote rules inline with the expected and rejected convention.

Feel free to merge after a rebase.

@ntwb
Copy link
Member

ntwb commented Jun 6, 2016

Nice, and a nice bump in coverage also 👍

Coverage increased (+1.2%) to 98.255%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants