-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecations #1385
Remove deprecations #1385
Conversation
@@ -171,27 +171,6 @@ test("module providing an array of plugins", t => { | |||
t.plan(planned) | |||
}) | |||
|
|||
test("deprecation warning for slashless plugin rule names", t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this test be replaced with a test to check for a config error? Or should the file plugin-slashless-warn-about-foo.js
be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, these are good ideas. Thanks for looking closely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In latest commit added a test, as you can see below.
Oh wow. Great to see this. I'm confident we're on a more sustainable trajectory with these removals. Thanks also for bringing the contextual quote rules inline with the Feel free to merge after a rebase. |
80c9bf5
to
b1549dc
Compare
Nice, and a nice bump in coverage also 👍
|
Addresses #1310.
As you can see from commits, I've tried to:
I believe that addresses all the checkboxes in #1310.
Of course the big points to help check here are: