Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit gray color and use dim instead #2003

Merged
merged 2 commits into from Oct 21, 2016
Merged

Remove explicit gray color and use dim instead #2003

merged 2 commits into from Oct 21, 2016

Conversation

kriansa
Copy link
Contributor

@kriansa kriansa commented Oct 20, 2016 •
edited

Closes #1996

@jeddy3
Copy link
Member

jeddy3 commented Oct 20, 2016

@kriansa Thanks for another contribution!

I believe gray is used a couple of times in the verboseFormatter as well. Can you please, for the sake of consistency, update those to use dim too?

@kriansa
Copy link
Contributor Author

kriansa commented Oct 21, 2016

Done. Could you review it?

@davidtheclark
Copy link
Contributor

👍 from me

@alexander-akait
Copy link
Member

@kriansa squash your commit in one for best commit history, thanks

@jeddy3
Copy link
Member

jeddy3 commented Oct 21, 2016

squash your commit in one for best commit history, thanks

We can do this ourselves via github's "squash and merge" feature :)

@jeddy3 jeddy3 merged commit dfabff2 into stylelint:master Oct 21, 2016
@jeddy3
Copy link
Member

jeddy3 commented Oct 21, 2016

@kriansa Thanks! LGTM i.e. exactly the same in iTerm2's default color scheme :)

@jeddy3
Copy link
Member

jeddy3 commented Oct 21, 2016

  • Fixed: the string and verbose formatters now use dim instead of gray for greater compatibility with different terminal color schemes.

sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017
@kriansa
Remove explicit gray color and use dim instead (stylelint#2003)
ced3e63 
* Remove explicit gray color and use dim instead

* Replace gray by dim in verbose formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kriansa @jeddy3 @davidtheclark @alexander-akait