Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): update table to version 4.0.1 #2106

Merged
merged 2 commits into from Nov 26, 2016
Merged

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Nov 23, 2016

Superseeds #2101

@ntwb
Copy link
Member Author

ntwb commented Nov 23, 2016

I'm not sure what is going on with Table v4.x.x to be honest, there is no changelog and all 4.x.x Table Travis CI build jobs have failed.

Here's a compare of the last 3.x.x to 4.x.x branch: gajus/table@v3.8.3...v4.0.1

Will need to look into that some more for further investigation

(If no one beats me to it I'll have more time tomorrow to investigate)

@alexander-akait
Copy link
Member

@ntwb maybe cache?

@ntwb
Copy link
Member Author

ntwb commented Nov 23, 2016

@evilebottnawi I don't think so, cache maintenance for Travis CI was added back in ebfec8a and not touched in AppVeyor. Also this PR is a fresh PR I created for Table v4.0.1, #2101 was for v4.0.0 and #2103 didn't have any issues.

@davidtheclark
Copy link
Contributor

We need to expel Table from our dependencies. I don't like having a dependency that does not include a changelog. Let's find another library.

@alexander-akait
Copy link
Member

alexander-akait commented Nov 23, 2016

eslint use https://github.com/substack/text-table in stylish formatter, but it is seem old library and many tests failed. In table formatter use table package.

@alexander-akait
Copy link
Member

alexander-akait commented Nov 23, 2016

I create issue, let's wait what says contributors

@gajus
Copy link

gajus commented Nov 23, 2016

I create issue, let's wait what says contributors

The only breaking change is how you import table.

See gajus/table#25 (comment)

In your code base, you simply need to replace:

import table from 'table';
// or
// const table = require('table').default;

with

import {table} from 'table';
// or
// const {table} = require('table');

@gajus
Copy link

gajus commented Nov 23, 2016

Sorry about the lack of changelog. I don't like the https://github.com/semantic-release/semantic-release tool (because it uses github's releases instead of a static changelog file) and there isn't a feasible alternative at the moment.

Please suggest how to add automated changelog to the CI gajus/table#27

@davidtheclark
Copy link
Contributor

@gajus If you don't have an automated changelog you need to have a manual one. That's what we do.

@gajus
Copy link

gajus commented Nov 23, 2016

@gajus If you don't have an automated changelog you need to have a manual one. That's what we do.

You, personally, don't appear to maintain 50+ open-source projects. Therefore, we have different problems to solve.

In most of the projects I use semantic-release. However, I have learned that migrating to other repositories (e.g. gitlab) renders the release log useless.

On other projects I have started to use a custom script (https://github.com/gajus/gitinfo/blob/master/.scripts/release.sh), which is working great, but it is in experimental state. I am planning to abstract a variation of it and release it as a tool. As soon as thats out of the door, I will enforce it on table as well as all other packages.

@gajus
Copy link

gajus commented Nov 23, 2016

You, personally, don't appear to maintain 50+ open-source projects. Therefore, we have different problems to solve.

Dammit. Said this without looking at the profile. Well, kudos for not being sloppy. :-)

I will do my best to remedy table changelog situation ASAP.

@ntwb
Copy link
Member Author

ntwb commented Nov 23, 2016

I restarted the failing Travis CI job and all jobs now pass, thanks @evilebottnawi for the commit 👍

@ntwb ntwb added PR: review needed and removed PR: needs revision status: needs investigation triage needs further investigation labels Nov 23, 2016
@davidtheclark
Copy link
Contributor

@gajus I understand budgeting your energy! Consider mine a vote for changelog a even at the expense of something else. I personally consider it a priority in dependencies that are not super simple. It can save me (the user) a lot of headaches and uncertainty. Anyway, thanks for your work on these OSS projects!

@jeddy3 jeddy3 merged commit ffb8633 into master Nov 26, 2016
@jeddy3 jeddy3 deleted the greenkeeper/table-4.0.1 branch November 26, 2016 10:53
sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017
* fix(package): update table to version 4.0.1

Closes stylelint#2101

https://greenkeeper.io/

* Fixed: update table to version 4.0.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants