Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Mark some parameters as booleans explicitly #2186

Merged
merged 1 commit into from
Dec 10, 2016

Conversation

subzey
Copy link
Contributor

@subzey subzey commented Dec 10, 2016

Which issue, if any, is this issue related to?

#2184

Is there anything in the PR that needs further explanation?

No.

Fixes #2184

This change states that --allow-empty-input, --color, --help,
--ignore-disables, --no-color, --quiet, --version has no arguments

Fixes stylelint#2184

This change states that --allow-empty-input, --color, --help,
--ignore-disables, --no-color, --quiet, --version has no arguments
@jeddy3 jeddy3 merged commit 5b078ee into stylelint:master Dec 10, 2016
@jeddy3
Copy link
Member

jeddy3 commented Dec 10, 2016

@subzey Thanks! LGTM.

@stylelint/core Tested locally and looks good. Changelog entry is:

  • Fixed: a boolean CLI flag (e.g. --quiet) placed before an input glob no longer causes the input to be ignored (#2186).

Need for better CLI tests is being tracked in #2046

@subzey subzey deleted the issue-2184-boolean-cli-flags branch December 10, 2016 15:53
sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017
Fixes stylelint#2184

This change states that --allow-empty-input, --color, --help,
--ignore-disables, --no-color, --quiet, --version has no arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

--quiet flag behavior is counter-intuitive
2 participants