Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extends in configOverrides #2295

Merged
merged 1 commit into from
Jan 29, 2017
Merged

Fix extends in configOverrides #2295

merged 1 commit into from
Jan 29, 2017

Conversation

davidtheclark
Copy link
Contributor

Closes #2280.

Adds a test that failed before the small change, reflecting the bug in #2280.

cc @veej

jeddy3
jeddy3 approved these changes Jan 29, 2017
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Tested locally and works as expected.

@davidtheclark davidtheclark merged commit 8ccc8fd into master Jan 29, 2017
@davidtheclark davidtheclark deleted the 2280-override-extends branch January 29, 2017 15:14
@davidtheclark
Copy link
Contributor Author

Added to Changelog:

  • Fixed: configOverrides now work with extends (#2295).

@keylocation-bot keylocation-bot mentioned this pull request Feb 2, 2017
Merged
sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017
@davidtheclark
Fix extends in configOverrides (stylelint#2295)
712a82d 
Closes stylelint#2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtheclark @jeddy3