Add support for async rules #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramasilveyra need add test 👍 |
ramasilveyra
force-pushed
the
support-async-rules
branch
from
c72a425
to
6486f2d
Compare
|
@evilebottnawi Tests added! 😀 |
davidtheclark
requested changes
Feb 18, 2017
There was a problem hiding this comment.
@ramasilveyra Nicely done! Glad it turned out to be simple. Can you please add some documentation so others will know async plugins are possible?
ramasilveyra
force-pushed
the
support-async-rules
branch
2 times, most recently
from
9fc8c69
to
54d102e
Compare
ramasilveyra
force-pushed
the
support-async-rules
branch
from
54d102e
to
81d3967
Compare
|
@davidtheclark Docs added :) My only concern it's that i'm not sure if I should have called this new doc section as Also I have to add the change to the # Head
- Added: Support for async rules ([#2351](https://github.com/stylelint/stylelint/pull/2351)). |
davidtheclark
requested changes
Feb 19, 2017
There was a problem hiding this comment.
@ramasilveyra Excellent! One editing point, then let's merge.
No need to add a note to the Changelog: we do that after merging.
docs/developer-guide/plugins.md
Outdated
| @@ -36,6 +36,39 @@ In order for your plugin rule to work with the [standard configuration format](. | |||
|
|
|||
| `ruleFunction` should return a function that is essentially a little [PostCSS plugin](https://github.com/postcss/postcss/blob/master/docs/writing-a-plugin.md): it takes 2 arguments: the PostCSS Root (the parsed AST), and the PostCSS LazyResult. You'll have to [learn about the PostCSS API](https://github.com/postcss/postcss/blob/master/docs/api.md). | |||
|
|
|||
| ### Asynchronous rules | |||
|
|
|||
| Rules with asynchronous PostCSS plugins are also possible you only need to return a Promise instance. | |||
There was a problem hiding this comment.
Let's add some punctuation here:
Rules with asynchronous PostCSS plugins are also possible! All you need to do is return a Promise instance from your plugin function.
davidtheclark
approved these changes
Feb 19, 2017
|
@ramasilveyra I made the copy edit suggestions directly — realized that I could do that easily with the GitHub UI! Will merge on CI green light. Thanks again. |
|
Added to changelog:
|
|
💥 Thanks all for your time! |
m-allanson
added a commit
that referenced
this pull request
Feb 22, 2017
* master: (107 commits) Update jest to the latest version 🚀 (#2372) fix(package): update known-css-properties to version 0.0.7 chore(package): update eslint to version 3.16.0 Update CHANGELOG.md Add support for async rules (#2351) Prepare 7.9.0 Add a test for a parent selector in no-duplicate-selectors (#2364) Update CHANGELOG.md Add ignorePattern option to max-line-length (#2333) no-browser-hacks: link to external plugin (#2365) Update CHANGELOG.md Fix placeholder selector case (#2360) Always exclude ignored globs from globby search. (#2355) Update CHANGELOG.md Update lodash (#2353) Update CHANGELOG.md Add ignoreFontFamilyName option to font-family-no-duplicate (#2314) Tests: added tests for nested selectors in `selector-id-pattern` rule. (#2345) Fix brace position (#2347) Update CHANGELOG.md ... # Conflicts: # .gitignore
hudochenkov
added a commit
that referenced
this pull request
Feb 23, 2017
* master: (31 commits) Update stylehacks and snapshot Update jest to the latest version 🚀 (#2372) fix(package): update known-css-properties to version 0.0.7 chore(package): update eslint to version 3.16.0 Update CHANGELOG.md Add support for async rules (#2351) Prepare 7.9.0 Add a test for a parent selector in no-duplicate-selectors (#2364) Update CHANGELOG.md Add ignorePattern option to max-line-length (#2333) no-browser-hacks: link to external plugin (#2365) Update CHANGELOG.md Fix placeholder selector case (#2360) Always exclude ignored globs from globby search. (#2355) Update CHANGELOG.md Update lodash (#2353) Update CHANGELOG.md Add ignoreFontFamilyName option to font-family-no-duplicate (#2314) Tests: added tests for nested selectors in `selector-id-pattern` rule. (#2345) Fix brace position (#2347) ... # Conflicts: # CHANGELOG.md
sergesemashko
pushed a commit
to sergesemashko/stylelint
that referenced
this pull request
Mar 3, 2017
* Add support for async rules * Copy editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with the intention of solve #2296: add support for async rules.