Add defaultIgnores: false option

[hudochenkov]

Which issue, if any, is this issue related to?

#2236

Is there anything in the PR that needs further explanation?

Changing default behaviour for ignoreFiles. User's config will override default values.

Should we somewhere in docs write default pattern? Users might want to add some patterns additionally to default patterns.

Also, what to do to this code which was added recently (9578c48).

[davidtheclark]

I think there's a significant problem here: #2399 (comment). The gist of it is that I can't think of an efficient way for ignoreFiles to work on large quantities of files that match the original input glob. A file will only be ignored via ignoreFiles after stylelint has loaded its relevant config and checked that config for ignoreFiles — which means using ignoreFiles to ignore node_modules will be significantly less efficient than the current implement @hudochenkov linked to.

[hudochenkov]

On the other side this code made impossible #2236. It ignores files which might not be ignored if ignoreFiles are specified.

[davidtheclark]

Uuuggggh.

Here's the only decent solution I can come up with for this mess:

• config.ignoreFiles comes with the caveat that it is not an efficient way to ignore a lot of files, because it is included in configs and configs are loaded for each file before they can be analyzed — so we don't know if the file is ignored until we've loaded its config.
• If you want to ignore lots of files efficiently, you need to do that in your input glob.
• node_modules and bower_components are by default ignored via the input glob (so, efficiently); and we can add a new option like defaultIgnores: false that turns this behavior off.

[hudochenkov]

Sorry, I don't have enough knowledge about ignoring files, and stylelint's architecture. I can't have strong opinion on that matter. I believe other team members could have a solution.

[TheXardas]

Gentlemen,
maybe a simple flag like "disableNodeModulesIgnore" would do?

[jeddy3]

Here's the only decent solution I can come up with for this mess:

SGTM. Let's document the limitation of config.ignoreFiles and how a more tailored input glob can be used as an alternative, and let's add a defaultIgnores: false option.

Am I right in thinking that such an option would no longer mean that this is a breaking change and we can point this PR (once it's adapted) to master?

maybe a simple flag like "disableNodeModulesIgnore" would do?

@TheXardas Thanks for chiming in. Yep, that is part of @davidtheclark's proposal.

[davidtheclark]

@jeddy3, I think I've realized a key here (#2399 (comment)): You can already load only one .stylelintignore — so we should change our strategy a bit so those patterns get incorporated into the glob. ignoreFiles will be the inefficient way to ignore things; .stylelintignore or your files glob the efficient way.

This will be a breaking change, though the break probably will not affect most users: the ignored and standaloneIgnored properties of stylelint results will no longer be the same, and files that are ignored via .stylelintignore will not show up in the results at all.

I'll try to prepare a PR to v8 today.

[jeddy3]

I think I've realized a key here (#2399 (comment)):

I saw that. SGTM.

I'll try to prepare a PR to v8 today.

Awesome! :)

[jeddy3]

Closing in favour of #2464