Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: selector-type-no-unknown now ignores MathML tags. #2478

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Conversation

alexander-akait
Copy link
Member

Which issue, if any, is this issue related to?

#2397

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also mention MathML in a readme, please.

@alexander-akait
Copy link
Member Author

/cc @hudochenkov done. I constantly forget about the documentation 😄

@@ -8,7 +8,7 @@ Disallow unknown type selectors.
* This type selector */
```

This rule considers tags defined in the HTML and SVG Specifications to be known.
This rule considers tags defined in the HTML and SVG and MathML Specifications to be known.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better:

This rule considers tags defined in the HTML, SVG, and MathML specifications to be known.

@alexander-akait
Copy link
Member Author

@hudochenkov done 😄

Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeddy3
Copy link
Member

jeddy3 commented Apr 7, 2017

Changelog:

  • Fixed: selector-type-no-unknown now ignores MathML tags (#2478).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants