New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: descendant combinator in `selector-descendant-combinator-no-non-space` and `selector-combinator-space-before/after` #2509

Merged
merged 2 commits into from Apr 22, 2017

Conversation

3 participants
@evilebottnawi
Member

evilebottnawi commented Apr 18, 2017

Which issue, if any, is this issue related to?

#2506

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

Fixed: `selector-descendant-combinator-no-non-space` is not don't rep…
…ort on shadow-piercing descendant combinator.
@jeddy3

Can you add brief tests to selector-combinator-space-after and selector-combinator-space-before please. They also make sure of lib/reference/punctuationSets.js, and should be fine.

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Apr 18, 2017

@jeddy3 I'm right now take their implementation (btw i think drop styleSearch in this rules and use postcss-selector-parser)

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Apr 18, 2017

(btw i think drop styleSearch in this rules and use postcss-selector-parser)

Let's only do that if it adds something e.g. clarity or performance etc.

If the selector-combinator-space-* rules work for >>> with a simple change the punctuation reference, then let's stick with that for now.

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Apr 18, 2017

@jeddy3 not working as expected because we have > and >>> and styleSearch found > 😭

@evilebottnawi evilebottnawi changed the title from Fixed: `selector-descendant-combinator-no-non-space` is not don't rep… to Fixed: `selector-descendant-combinator-no-non-space` is not don't report on shadow-piercing descendant combinator Apr 18, 2017

Fixed: `selector-combinator-space-after` and `selector-combinator-spa…
…ce-before` is now support `>>>` shadow-piercing descendant combinator.

@evilebottnawi evilebottnawi changed the title from Fixed: `selector-descendant-combinator-no-non-space` is not don't report on shadow-piercing descendant combinator to Fixed: descendant combinator in `selector-descendant-combinator-no-non-space` and `selector-combinator-space-before/after` Apr 18, 2017

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Apr 18, 2017

Sorry for big commit, but i think it should be done together
One note: selector-combinator-space-before/after don't support /deep/ (and other reference selectors) (because postcss-selector-parse don't works with their, theoretically we can write isReferenceSelector). I think we can leave this commit as it is and next commit i can see how handle reference selectors in this rules (maybe need see other rules).

/cc @jeddy3

@jeddy3

jeddy3 approved these changes Apr 19, 2017

LGTM

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Apr 19, 2017

One note: selector-combinator-space-before/after don't support /deep/ (and other reference selectors)

Yes, that's fine. Enforcing spacing around /deep/ will need to be a separate issue as it's a breaking change - feel free to create a new issue for this. The changes in this PR are fixes so that >>> isn't mistaken for >.

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Apr 19, 2017

@jeddy3 it think issue already created #2506, even the name it shows 😄

@davidtheclark davidtheclark merged commit 484b135 into master Apr 22, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 95.485%
Details

@davidtheclark davidtheclark deleted the issue-2506-selector-descendant-combinator-no-non-space branch Apr 22, 2017

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Apr 22, 2017

Added to changelog:

  • Fixed: selector-descendant-combinator-no-non-space and selector-combinator-space-before/after now understand and check >>> shadow-piercing combinator (#2509).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment