Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Indentation autofixing #2529
I've made autofixing for most use cases. These use cases was analyzed with PostCSS AST, so I could easily apply fixes. But for big number of other use cases this rule uses
I haven't figured out how to deal with this yet. I've commented all
Any suggestions how to deal with this problem?
Also there is a problem with Less syntax. I haven't investigate what causes the problem yet.
In order to finish this PR we need:
P. S. It was total surprise to me, that this rule has secondary options
Error log with Less mixins and autofixing
Semicolon gets removed.
I think in #2259 we decided that advanced features like autofixing would only be for standard-syntax. We don't want to repeat the path of stylefmt where the project stagnated due to the quantity of non-standard bugs for this advanced feature. I think we can remove any non-standard tests and make it clear within the documentation that autofix is a standard-syntax only feature. I'm still plugging away at a
@jeddy3 I believe that we should not touch anything what don't pass
if someone will want to use their fixes, I do not think that it will be difficult to implement
I think if we can add fixing to a rule, we should fix as much as we can. Maybe we can't do fixing for some options of a rule. It's ok, we'll show linting error as usual. Or if we can't be sure about consistency of fixing for particular options or rule, we won't add fixing, because it could be auto-breaking instead of auto-fixing.
Let's return to this PR :)
What should I do with part which checks code using
changed the title from
[WIP] Indentation autofixing
May 7, 2017
I haven't found a way how to rewrite this rule away from style-search, because it's very complex. But I finally figured out how to add autofixing for the code that uses style-search!
Less is still broken, because of semicolon bug in postcss-less. That's why tests without
@stylelint/core PR is ready for a review.
Shall we merge this and #2577, and then get out experimental support for autofixing (for standard syntax)?
We're only a couple of issues away from getting
Jun 9, 2017
Thank you for a review!
For some reason Github named commit as “Create CHANGELOG.md”.
I'm in a similar situation. When we started working on stylelint I was on a hiatus from agency work, but now my time is being consumed by non-open source work. I'm going to try to make some time to help get