Fixed: ignore less guards in selector-descendant-combinator-no-non-space.

[alexander-akait]

Which issue, if any, is this issue related to?

#2110

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

[jeddy3]

Does this heuristic introduce a false negative for this valid CSS?

when     a { }

Where when is an unknown, yet valid, type selector.

[alexander-akait]

@jeddy3 hm, right, let's add more complexly check

[alexander-akait]

/cc @jeddy3

[jeddy3]

Thanks. Can we add get truthy tests in the util for a when {} and when a {} please?

[alexander-akait]

/cc @jeddy3 done

[jeddy3]

LGTM

[davidtheclark]

only a whitespace can separate when and (, right? when\s+\(.*?\)

[alexander-akait]

@davidtheclark no, allow use when not (@variable = true)

[davidtheclark]

I think the regexp should account for this limited scenario, instead of allowing for any arbitrary characters between when and (.

[alexander-akait]

@davidtheclark in theory allow when not not (@variable = true) (does not make sense)

[davidtheclark]

@evilebottnawi: You can make the regexp as complicated as you think necessary — but I think it's not great to make it so simple that it might raise false positives.

[alexander-akait]

@davidtheclark What solution is better to use here?

[davidtheclark]

How about /when\s+(not\s+)*\(/? I think it will just take writing tests for what should and should not work and fiddling with the regexp until that's what happens.

[alexander-akait]

/cc @davidtheclark

[davidtheclark]

👍

[jeddy3]

Changelog:

• Fixed: selector-descendant-combinator-no-non-space now ignores Less guards (#2557).