Added: selector-max-combinators rule.
#2658
Conversation
docs/user-guide/rules.md
Outdated
| @@ -163,6 +163,7 @@ Here are all the rules within stylelint, grouped by the [*thing*](http://apps.wo | |||
| - [`selector-descendant-combinator-no-non-space`](../../lib/rules/selector-descendant-combinator-no-non-space/README.md): Disallow non-space characters for descendant combinators of selectors. | |||
| - [`selector-id-pattern`](../../lib/rules/selector-id-pattern/README.md): Specify a pattern for id selectors. | |||
| - [`selector-max-class`](../../lib/rules/selector-max-class/README.md): Limit the number of classes in a selector. | |||
| - [`selector-max-combinators`](../../lib/rules/selector-max-combinators/README.md): Limit the number of combinators selectors in a selector. | |||
There was a problem hiding this comment.
"Limit the number of combinators in a selector."
There was a problem hiding this comment.
@evilebottnawi Thanks for this.
I've made some doc and message requests.
Remember to update the example config and rules list docs in this PR.
I'm out of time and yet to look at the tests I'm afraid.
| @@ -0,0 +1,61 @@ | |||
| # selector-max-combinators | |||
|
|
|||
| Limit the number of combinators selectors in a selector. | |||
There was a problem hiding this comment.
"Limit the number of combinators in a selector."
| ``` | ||
|
|
||
| ```css | ||
| a, b {} |
There was a problem hiding this comment.
Use a b ~ c here for parity with positive patterns.
| ``` | ||
|
|
||
| ```css | ||
| a.foo {} |
There was a problem hiding this comment.
Use the following instead here:
a b {
& ~ c {}
}| ``` | ||
|
|
||
| ```css | ||
| /* each selector in a selector list is evaluated separately */ |
There was a problem hiding this comment.
Use the following instead:
a b,
c > d {}| const ruleName = "selector-max-combinators" | ||
|
|
||
| const messages = ruleMessages(ruleName, { | ||
| expected: (selector, max) => `Expected "${selector}" to have no more than ${max} combinators ${max === 1 ? "selector" : "selectors"}`, |
There was a problem hiding this comment.
expected: (selector, max) => `Expected "${selector}" to have no more than ${max} ${max === 1 ? "combinator" : "combinators"}`,
alexander-akait
force-pushed
the
selector-max-combinators
branch
from
8a9fced
to
7ed5ad9
Compare
|
@jeddy3 done, about tests: all tested was migrate from basic rules and add more tests, in theory all should be fine. Btw, if someone found error we just fix it and release patch version. |
| description: "pseudo selectors", | ||
| }, { | ||
| code: "foo bar, \nbaz quux {}", | ||
| description: "multiple selectors: exactly max id selectors", |
There was a problem hiding this comment.
“multiple selectors: fewer then max combinators selectors”
|
@hudochenkov Changes made. |
jeddy3
force-pushed
the
selector-max-combinators
branch
from
7d85fd5
to
52c184e
Compare
|
#2528
No, it's self explanatory.