New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle valid calc functions with no whitespace in unit-no-unknown (issue #2551) #2848

Merged
merged 3 commits into from Sep 10, 2017

Conversation

4 participants
@CAYdenberg
Contributor

CAYdenberg commented Sep 4, 2017

Which issue, if any, is this issue related to?

Issue #2551

Is there anything in the PR that needs further explanation?

The solution is stupidly simple but it works (as in the tests pass). There might be edge cases I haven't thought of though.

@CAYdenberg CAYdenberg changed the title from Issue 2551 2 to Handle valid calc functions with no whitespace in unit-no-unknown (issue #2551) Sep 4, 2017

@ntwb

This comment has been minimized.

Member

ntwb commented Sep 4, 2017

@CAYdenberg Thanks, could you please update your branch so that the npm 5 change I just merged is added to your branch that should fix the Travis CI test failure in this PR please 😄

@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Sep 4, 2017

I can never seem to stay awake until the build finishes 🛌
Hopefully that does it

@jeddy3

jeddy3 approved these changes Sep 10, 2017

@CAYdenberg Thanks@ LGTM as a suitable workaround for now.

@evilebottnawi

evilebottnawi approved these changes Sep 10, 2017 edited

Thanks, @CAYdenberg can you create issue about support calc functions with no whitespace in other unit-* rules, otherwise, we can forget this

@jeddy3 jeddy3 merged commit 195925a into stylelint:master Sep 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 95.65%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 10, 2017

  • Fixed: unit-no-unknown false positives for spaceless multiplication and division in calc() functions (#2848).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment