Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle valid calc functions with no whitespace in unit-no-unknown (issue #2551) #2848

Merged
merged 3 commits into from Sep 10, 2017
Merged

Handle valid calc functions with no whitespace in unit-no-unknown (issue #2551) #2848

merged 3 commits into from Sep 10, 2017

Conversation

CAYdenberg
Copy link
Contributor

Which issue, if any, is this issue related to?

Issue #2551

Is there anything in the PR that needs further explanation?

The solution is stupidly simple but it works (as in the tests pass). There might be edge cases I haven't thought of though.

@CAYdenberg CAYdenberg changed the title Issue 2551 2 Handle valid calc functions with no whitespace in unit-no-unknown (issue #2551) Sep 4, 2017
@ntwb
Copy link
Member

ntwb commented Sep 4, 2017

@CAYdenberg Thanks, could you please update your branch so that the npm 5 change I just merged is added to your branch that should fix the Travis CI test failure in this PR please 😄

@CAYdenberg
Copy link
Contributor Author

I can never seem to stay awake until the build finishes 🛌
Hopefully that does it

jeddy3
jeddy3 approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CAYdenberg Thanks@ LGTM as a suitable workaround for now.

alexander-akait
alexander-akait approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CAYdenberg can you create issue about support calc functions with no whitespace in other unit-* rules, otherwise, we can forget this

@jeddy3 jeddy3 merged commit 195925a into stylelint:master Sep 10, 2017
@jeddy3
Copy link
Member

jeddy3 commented Sep 10, 2017

  • Fixed: unit-no-unknown false positives for spaceless multiplication and division in calc() functions (#2848).

@CAYdenberg CAYdenberg mentioned this pull request Sep 10, 2017
Closed
@jeddy3 jeddy3 mentioned this pull request Sep 12, 2017
Merged
@CAYdenberg CAYdenberg mentioned this pull request Sep 17, 2017
Closed
@dependencies dependencies bot mentioned this pull request Dec 5, 2017
Merged
This was referenced Mar 14, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CAYdenberg @ntwb @jeddy3 @alexander-akait