Document key deprecating rule points #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, fixed the lint warnings. This is ready for review now. |
ntwb
requested changes
Sep 10, 2017
docs/developer-guide/rules.md
Outdated
| @@ -249,6 +249,13 @@ Fixing bugs is usually very easy. Here is a process that works: | |||
|
|
|||
| That's it! **If you are unable to figure out how to fix the bug yourself, it is still helpful to submit a pull request with your failing test cases.** It means that somebody else can jump right in and help out with the rule's logic. | |||
|
|
|||
| ## Deprecating a rule | |||
|
|
|||
| Deprecating rules doesn't happened very often. However, these two steps are important to do: | |||
ntwb
reviewed
Sep 10, 2017
docs/developer-guide/rules.md
Outdated
|
|
||
| Deprecating rules doesn't happened very often. However, these two steps are important to do: | ||
|
|
||
| 1. Point the `stylelintReference` link to the specific version of the rule README on GitHub website, so that it is always accessible. |
There was a problem hiding this comment.
Add a the so it's on the GitHub website rather than on GitHub website
|
@ntwb Thanks for the feedback... silly typos from writing docs in the wee hours :) |
|
@ntwb Amends incorporated. Ready for review again. |
hudochenkov
approved these changes
Sep 12, 2017
ntwb
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2804
Closes #2622
Documenting this so that we can close the above two issues.