Add ignoreUnits option to number-max-precision rule #2941
Conversation
There was a problem hiding this comment.
@sendilkumarn Thanks for this!
I've made a couple of test and docs requests as the option also accepts regexs.
Can you also remove the CHANGELOG item (as we do that after the PR is merged to avoid conflicts) and the yarn.lock file.
Note: let's add yarn.lock to .gitignore in another PR.
| @@ -37,3 +37,46 @@ a { top: 3.24px; } | |||
| ```css | |||
| @media (min-width: 3.23em) {} | |||
| ``` | |||
| ## Optional secondary options | |||
There was a problem hiding this comment.
Please add one blank line above the heading.
(Note: Let's see if remark can lint for this).
| @@ -37,3 +37,46 @@ a { top: 3.24px; } | |||
| ```css | |||
| @media (min-width: 3.23em) {} | |||
| ``` | |||
| ## Optional secondary options | |||
|
|
|||
| ### `ignoreUnits: ["string"]` | |||
There was a problem hiding this comment.
The optionsMatches util accepts regular expressions as well as strings. Can you update the examples to reflect this please, like so? e.g.
["/^my-/", "%"]a { top: 3.245my-unit; }|
|
||
| testRule(rule, { | ||
| ruleName, | ||
| config: [0, { ignoreUnits: ["%"] }], |
There was a problem hiding this comment.
Can we get update the config to:
ignoreUnits: ["%", "/^my-/"]
And get an accept and reject test for the "/^my-/" value.
sendilkumarn
force-pushed
the
ignore-num-max-precision
branch
from
520b777
to
d22eabb
Compare
|
@jeddy3 done the changes. 👍 |
There was a problem hiding this comment.
@sendilkumarn Thanks for making the changes (and for the other PRs!).
I've two very minor doc requests, then I think this is ready.
|
|
||
| ## Optional secondary options | ||
|
|
||
| ### `ignoreUnits: ["string"]` |
There was a problem hiding this comment.
### ignoreUnits: ["/regex/", "string"]
|
|
||
| ### `ignoreUnits: ["string"]` | ||
|
|
||
| Ignore number-max-precision rule for the value with the unit. |
There was a problem hiding this comment.
Can we use the following description, please:
"Ignore the precision of numbers for values with the specified units."
As it's more consistent with the descriptions else where.
adding regex option fixing comments
sendilkumarn
force-pushed
the
ignore-num-max-precision
branch
from
d22eabb
to
e31a988
Compare
|
#2785
No, it's self explanatory